e2e reflection Sphere snapshot #1901
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
abernier
commented
Apr 3, 2024
| @@ -15,7 +15,7 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| main: | |||
| runs-on: ubuntu-latest | |||
| runs-on: macos-14 | |||
abernier
force-pushed
the
test-env
branch
2 times, most recently
from
bfd6501
to
6477459
Compare
abernier
force-pushed
the
test-env
branch
3 times, most recently
from
9d60120
to
428f7ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
YES
In the e2e scene, replace the Box with a Sphere that reflects the Env
BUT
Problem: there are discrepancies in the generated image between m1 (my local machine where I've generated the snapshot) and intel processors (on CI, currently
macos-13) => upgrade toruns-on: macos-14which runs on m1 but then, we are facing another problem, where this image does not have access to a GPU, leading to:see: https://chat.openai.com/share/534072fe-2646-4a59-9397-b0abb152603f
POSSIBLE Solution
Wait
macos-14gh action image, has access to GPU...What
Checklist