Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path default value in useEnvironment.tsx #1872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dipanjanpanja6
Copy link

Why

path & files params not working in useEnvironment function

What

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:47pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@drcmda
Copy link
Member

drcmda commented Apr 2, 2024

im not sure @dipanjanpanja6 by default it's supposed to resolve px.png, nx.png et al at the /public root, so path = ''. it does not work if these files aren't there but that's expected. this would switch the default path to the githack uri where the presents are hosted but that's very different from how the api has always worked.

@dipanjanpanja6
Copy link
Author

If I send the preset params, the path is overridden by CUBEMAP_ROOT. It shouldn't be overridden if I provide a path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants