Implement Saddle & Horse Armor

[pandaa-be]

Introduction

Implement Saddle & Horse Armor.

(Currently this is just for cosmetic because there are no mobs in pocketmine but I need this for my mob plugin :P)

Changes

API changes

VanillaItems::SADDLE()
VanillaItems::LEATHER_HORSE_ARMOR()
VanillaItems::IRON_HORSE_ARMOR()
VanillaItems::DIAMOND_HORSE_ARMOR()
VanillaItems::GOLDEN_HORSE_ARMOR()

Tested LEATHER_HORSE_ARMOR custom colour with following code:

> 	public function onJoin(PlayerJoinEvent $event): void{
> 		$player = $event->getPlayer();
> 		$inventory = $player->getInventory();
> 
> 		$inventory->clearAll();
> 
> 		$inventory->addItem(VanillaItems::LEATHER_HORSE_ARMOR()->setCustomColor(new Color(500, 100, 254)));
> 		$inventory->addItem(VanillaItems::LEATHER_HORSE_ARMOR());
> 		$inventory->addItem(VanillaItems::IRON_HORSE_ARMOR());
> 		$inventory->addItem(VanillaItems::DIAMOND_HORSE_ARMOR());
> 		$inventory->addItem(VanillaItems::GOLDEN_HORSE_ARMOR());
> 		$inventory->addItem(VanillaItems::SADDLE());
> 	}

Tests

I tested this PR by doing the following (tick all that apply):

• Playtesting using a Minecraft client
  

[pandaa-be]

Is it enough if it stays as it is now (as I said, there are no mobs) or should I add the Horse Armor to Living::attack() anyway?

[ShockedPlot7560]

You need to regenerate the static functions

[pandaa-be]

You need to regenerate the static functions

for whatever reason i can't run the file on my laptop.

can do that when i am back at the pc 👌

[pandaa-be]

Is it enough if it stays as it is now (as I said, there are no mobs) or should I do more?

[ShockedPlot7560]

As the PR name and objective is to add these items and not the horse logics, its enough.

[ipad54]

Cauldron behaviour is also missing. In vanilla, leather armour can be dyed in cauldron.

[pandaa-be]

Cauldron behaviour is also missing. In vanilla, leather armour can be dyed in cauldron.

Jup but this is currently not implemented in pocketmine and I don´t feel like it is something for this pr..

[ipad54]

Jup but this is currently not implemented in pocketmine and I don´t feel like it is something for this pr..

What do you mean? Cauldron is implemented

[pandaa-be]

prove that it works