Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented anvil functionality #6305

Draft
wants to merge 7 commits into
base: minor-next
Choose a base branch
from
Draft

Implemented anvil functionality #6305

wants to merge 7 commits into from

Conversation

HimmelKreis4865
Copy link
Contributor

Introduction

Anvils did not work, now they do

warning: This is a WIP pr, there are some missing things:

  • The whole system is not tested out, some XP calculations could be invalid (in theory everything works though)
  • No validation of the SmithingTransaction (no idea how to validate the transaction because the items are in random order)
  • Sounds are not yet added
  • Anvil doesn't get damaged
  • I'm not too happy about the current codestyle

(This pr is mainly for getting inspiration during the development process)

@HimmelKreis4865 HimmelKreis4865 marked this pull request as draft March 24, 2024 21:32
@ShockedPlot7560 ShockedPlot7560 added Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP Status: Incomplete Work in progress and removed Category: API Related to the plugin API Category: Core Related to internal functionality labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Incomplete Work in progress Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HimmelKreis4865 @ShockedPlot7560