Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shield (wip) #6296

Draft
wants to merge 21 commits into
base: minor-next
Choose a base branch
from
Draft

Implement Shield (wip) #6296

wants to merge 21 commits into from

Conversation

pandaa-be
Copy link
Contributor

@pandaa-be pandaa-be commented Mar 22, 2024

Introduction

This PR adds working shield.

this will have a lot of commits because i am working on 2 different desktops and this is the best way for me to save the files sry bros

Changes

API changes

VanillaItems::SHIELD()
Item::canDisableShield() in Item.php & Axe.php

Tests

I tested this PR by doing the following (tick all that apply):

  • Playtesting using a Minecraft client (provide screenshots or a video)

@ShockedPlot7560 ShockedPlot7560 added Category: Gameplay Related to Minecraft gameplay experience Status: Incomplete Work in progress Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Mar 23, 2024
@pandaa-be pandaa-be changed the title Implement Shield Implement Shield (wip) Mar 24, 2024
Copy link
Contributor

@JavierLeon9966 JavierLeon9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of naming the methods and properties breakShield it should be like "shield disabled". canDisableShield, isShieldDisabled, getShieldDisableCooldown, etc.

src/entity/Human.php Outdated Show resolved Hide resolved
src/entity/Living.php Show resolved Hide resolved
src/entity/Living.php Outdated Show resolved Hide resolved
src/entity/Living.php Outdated Show resolved Hide resolved
src/entity/Living.php Outdated Show resolved Hide resolved
src/event/entity/EntityDamageBlockedEvent.php Outdated Show resolved Hide resolved
src/item/Shield.php Outdated Show resolved Hide resolved
src/player/Player.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Incomplete Work in progress Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants