New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing Nether Blocks #6276
Open
pandaa-be
wants to merge
44
commits into
pmmp:minor-next
Choose a base branch
from
pandaa-be:nylium
base: minor-next
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaa-be
changed the title
Implement some Nether Blocks
Implement missing Nether Blocks
Mar 17, 2024
ShockedPlot7560
added
Category: Gameplay
Related to Minecraft gameplay experience
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
labels
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some PHPstan issues need to be adressed
the only problem left is that the re-generated actual-problems.neon removes following thing:
Should I just copy & paste it in the file? lol |
Is this pr finished or is something left? I ask because of the Label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Gameplay
Related to Minecraft gameplay experience
Status: Waiting on Author
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This plugin adds follow things:
Note: Bone Meal logic for Fungus is currently missing and is not planned in this pull request
Project Card: https://github.com/pmmp/PocketMine-MP/projects/14#card-84464878
(reopened due of unresolved conflicts of the old pr)
Changes
API changes
VanillaBlocks::CRIMSON_NYLIUM(), VanillaBlocks::WARPED_NYLIUM(), VanillaBlocks::CRIMSON_FUNGUS(), VanillaBlocks::WARPED_FUNGUS(), VanillaBlocks::NETHER_SPROUTS()
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunit
folder)