Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing Nether Blocks #6276

Open
wants to merge 44 commits into
base: minor-next
Choose a base branch
from
Open

Conversation

pandaa-be
Copy link
Contributor

@pandaa-be pandaa-be commented Mar 4, 2024

Introduction

This plugin adds follow things:

  • Crimson Nylium/Fungus, Waped Nylium/Fungus, Nether Sporuts
  • Bone Meal Logic for Netherrack
  • Adds support for Nylium to Mushrooms
  • Adds support for Nylium to NetherRoots

Note: Bone Meal logic for Fungus is currently missing and is not planned in this pull request

Project Card: https://github.com/pmmp/PocketMine-MP/projects/14#card-84464878

(reopened due of unresolved conflicts of the old pr)

Changes

API changes

VanillaBlocks::CRIMSON_NYLIUM(), VanillaBlocks::WARPED_NYLIUM(), VanillaBlocks::CRIMSON_FUNGUS(), VanillaBlocks::WARPED_FUNGUS(), VanillaBlocks::NETHER_SPROUTS()

Tests

I tested this PR by doing the following (tick all that apply):

  • Writing PHPUnit tests (commit these in the tests/phpunit folder)
  • Playtesting using a Minecraft client (provide screenshots or a video)
    grafik

@pandaa-be pandaa-be changed the title Implement some Nether Blocks Implement missing Nether Blocks Mar 17, 2024
@pandaa-be pandaa-be marked this pull request as ready for review March 17, 2024 18:11
src/block/Fungus.php Outdated Show resolved Hide resolved
src/block/NetherSprouts.php Outdated Show resolved Hide resolved
src/block/NetherSprouts.php Outdated Show resolved Hide resolved
src/block/Netherrack.php Outdated Show resolved Hide resolved
src/block/Nylium.php Show resolved Hide resolved
src/block/RedMushroom.php Outdated Show resolved Hide resolved
@ShockedPlot7560 ShockedPlot7560 added Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Mar 21, 2024
src/block/Fungus.php Outdated Show resolved Hide resolved
src/block/VanillaBlocks.php Outdated Show resolved Hide resolved
src/block/VanillaBlocks.php Outdated Show resolved Hide resolved
src/block/VanillaBlocks.php Outdated Show resolved Hide resolved
src/block/NetherSprouts.php Outdated Show resolved Hide resolved
src/block/Nylium.php Outdated Show resolved Hide resolved
src/block/RedMushroom.php Show resolved Hide resolved
src/block/Nylium.php Show resolved Hide resolved
src/block/Fungus.php Outdated Show resolved Hide resolved
src/block/NetherRoots.php Outdated Show resolved Hide resolved
src/block/NetherSprouts.php Outdated Show resolved Hide resolved
src/block/Netherrack.php Show resolved Hide resolved
src/block/Nylium.php Show resolved Hide resolved
src/block/Nylium.php Show resolved Hide resolved
Copy link
Member

@ShockedPlot7560 ShockedPlot7560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some PHPstan issues need to be adressed

@pandaa-be
Copy link
Contributor Author

pandaa-be commented Mar 26, 2024

the only problem left is that the re-generated actual-problems.neon removes following thing:

		-
			message: "#^Parameter \\#1 \\$logFile of class pocketmine\\\\utils\\\\MainLogger constructor expects string, string\\|false given\\.$#"
			count: 1
			path: ../../phpunit/scheduler/AsyncPoolTest.php

Should I just copy & paste it in the file? lol

@pandaa-be pandaa-be changed the base branch from minor-next to stable March 26, 2024 12:38
@pandaa-be pandaa-be changed the base branch from stable to minor-next March 26, 2024 12:38
@pandaa-be
Copy link
Contributor Author

Is this pr finished or is something left? I ask because of the Label

src/block/VanillaBlocks.php Outdated Show resolved Hide resolved
src/block/Nylium.php Outdated Show resolved Hide resolved
src/block/Nylium.php Outdated Show resolved Hide resolved
src/block/VanillaBlocks.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Waiting on Author Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants