New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement blocks ticking per world API #6204
Open
ShockedPlot7560
wants to merge
4
commits into
pmmp:minor-next
Choose a base branch
from
ShockedPlot7560:feat/rdm-tick-speed
base: minor-next
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement blocks ticking per world API #6204
ShockedPlot7560
wants to merge
4
commits into
pmmp:minor-next
from
ShockedPlot7560:feat/rdm-tick-speed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShockedPlot7560
added
Category: API
Related to the plugin API
Category: Core
Related to internal functionality
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
labels
Dec 20, 2023
dktapps
reviewed
Dec 20, 2023
dktapps
reviewed
Dec 20, 2023
This comment was marked as spam.
This comment was marked as spam.
dktapps
reviewed
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the method names are too esoteric for anyone to ever actually use them. Can we simplify these names at all without losing the meaning?
@@ -215,6 +215,7 @@ worlds: | |||
# seed: 404 | |||
# generator: FLAT | |||
# preset: 2;bedrock,59xstone,3xdirt,grass;1 | |||
# blocks-per-subchunk-per-tick: xx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# blocks-per-subchunk-per-tick: xx | |
# blocks-per-subchunk-per-tick: 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: API
Related to the plugin API
Category: Core
Related to internal functionality
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We already support to change the random tick speed in server, however we can't control which world or change it at runtime. This PR fix that by providing an API and adding new configuration key.
Relevant issues
Changes
API changes
Adding the following functions to
World
:setTickedBlocksPerSubchunkPerTick
getTickedBlocksPerSubchunkPerTick
Adding a new event
WorldTickedBlocksChangeEvent
which is fired when the value of tickedBlocksPerSubchunkPerTick change (not at the initialisation).Backwards compatibility
No
Follow-up
Change the configuration nested the worlds per-tick and the default value under a
blocks-per-subchunk-per-tick