Implemented smithing table functionality #6202
Conversation
ShockedPlot7560
added
Category: API
| $this->session->getLogger()->debug("Sending armor trim data"); | ||
| $patterns = array_map(fn(ArmorTrimPattern $pattern) => new TrimPattern($pattern->getItemId(), $pattern->value), ArmorTrimPattern::cases()); | ||
| $materials = array_map(fn(ArmorTrimMaterial $material) => new TrimMaterial($material->value, $material->getColor(), $material->getItemId()), ArmorTrimMaterial::cases()); | ||
| $this->session->sendDataPacket(TrimDataPacket::create($patterns, $materials)); |
There was a problem hiding this comment.
Is this customizable? If so, why are we using hard enums for this?
There was a problem hiding this comment.
@HimmelKreis4865 I don't know about patterns, but colours can be definitely customized. (For example, I can change the amethyst colour from purple to white). What do you think about allowing plugins to customize this?
There was a problem hiding this comment.
yeah I'm aware of this, and this should be customizable but I did not yet find a solution for this problem that satisfies me
There was a problem hiding this comment.
I pushed a commit to make this all customizable, please tell me what you think of this
There was a problem hiding this comment.
To me it looks good, but I'm not sure about passing type id and serialized item name to the constructor. Wouldn't a better to pass an Item and then serialize it when sending TrimData?
(from ipad54 on discord)
what do you guys think about this?
|
There's not much more I can do at this point, everthing is fixed except for save ids. |
This comment was marked as off-topic.
This comment was marked as off-topic.
HimmelKreis4865
force-pushed
the
smithing-table
branch
from
3999602
to
5360b77
Compare
|
|
|
yeah, ready to be reviewed again. |
| * @param Item[] $inputs | ||
| * @phpstan-param list<Item> $inputs | ||
| */ | ||
| public function getResultFor(array $inputs) : ?Item{ |
There was a problem hiding this comment.
I'm sceptical about the fact that it's up to the recipe to find out what the input is.
There was a problem hiding this comment.
tbh I don't see a problem here, it also has 2 usages so I don't know how I'd change it smoothly..
There was a problem hiding this comment.
is this relevant now? If so, please give me some more information on where to move the methods
| * @param Item[] $inputs | ||
| * @phpstan-param list<Item> $inputs | ||
| */ | ||
| public function getResultFor(array $inputs) : ?Item{ |
Introduction
This PR adds working smithing tables to pocketmine.
There are no known issues or problems
Changes
API changes
Amor->setTrim(ArmorTrim)Armor->getTrim() : ?ArmorTrimArmor->clearTrim()SmithingTableInventory->getInput() : ItemSmithingTableInventory->getAddition() : ItemSmithingTableInventory->getTemplate() : ItemThe new enums:
ArmorTrimPattern&ArmorTrimMaterial(required to constructArmorTrim)Tests
Tested ingame with the smithing table several times:
Tested the code