Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone arguments to callback hooks #111

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vancemiller
Copy link

@vancemiller vancemiller commented Jul 23, 2021

Forwards all arguments from clone to the parent and child hook functions. Additionally, allows the parent hook to set the returned PID if desired. Updates the clone test case to verify arguments are correctly forwarded.

Very similar to PR #102 but also updates the test case.


This change is Reviewable

Vance Miller added 4 commits July 23, 2021 14:24
Pass through the original arguments to clone and add a pointer to the return value.

This allows the hook to modify the returned PID if desired
@codecov-commenter
Copy link

Codecov Report

Merging #111 (58e3205) into master (2c8765f) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   91.98%   92.29%   +0.31%     
==========================================
  Files          12       12              
  Lines         973      974       +1     
==========================================
+ Hits          895      899       +4     
+ Misses         78       75       -3     
Flag Coverage Δ
pmemfile_tests 86.28% <33.33%> (+0.04%) ⬆️
regular_tests 91.17% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libsyscall_intercept_hook_point.h 50.00% <ø> (ø)
src/intercept.c 81.59% <100.00%> (+0.73%) ⬆️
src/intercept_log.c 95.60% <0.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8765f...58e3205. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants