Add hashtable-on-dram option #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set to no to keep expected dram-pmem ratio for small object size e.g. 32 bytes for 1:16 ratio - restore generic zfree mechanism in dict module - Hashtable is initialized before reading config - so it could be on dram or pmem, despite the selected hashtable-on-dram option Co-authored-by: jschmieg <jakub.schmiegel@intel.com>
|
Can one of the admins verify this patch? |
PatKamin
added a commit
to PatKamin/redis
that referenced
this pull request
Oct 28, 2022
[4.0.11-devel] Fix make test failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32 bytes for 1:16 ratio
initialized before reading config - so it could be on dram or pmem,
despite the selected hashtable-on-dram option
Co-authored-by: jschmieg jakub.schmiegel@intel.com
This change is