-
Notifications
You must be signed in to change notification settings - Fork 14
Add test for handling exception in callback functions #50
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
test/database_spec.js, line 332 at r1 (raw file):
db.get_keys_below('B', ex); } catch (e) { expect(e.message).to.equal('TestException');
This test fails ... ?
test/database_spec.js, line 332 at r1 (raw file): Previously, ldorau (Lukasz Dorau) wrote…
Yes, it fails. It's test for this issue #51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
test/database_spec.js, line 332 at r1 (raw file):
Previously, karczex wrote…
Yes, it fails. It's test for this issue #51
So when this test will not fail?
test/database_spec.js, line 332 at r1 (raw file): Previously, ldorau (Lukasz Dorau) wrote…
I don't know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
test/database_spec.js, line 332 at r1 (raw file):
Previously, karczex wrote…
I don't know.
Ah, so this PR just waits for a fix?
test/database_spec.js, line 332 at r1 (raw file): Previously, ldorau (Lukasz Dorau) wrote…
Yes, it's bug reproducer. Unfortunately build system doesn't support tests which are failing. I think this PR may stay as draft until fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)
test/database_spec.js, line 332 at r1 (raw file):
Previously, karczex wrote…
Yes, it's bug reproducer. Unfortunately build system doesn't support tests which are failing. I think this PR may stay as draft until fixed.
I see, OK
This change is