This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
posix: disable space overallocation on append & fix 16k blocks tests #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the end of file Not caught because rw test is not executed for 16k block size.
Current block sizes are 16k, 256k and 2M, so there's no point in allocating more than 2M.
marcinslusarz
changed the title
|
Reviewed 6 of 6 files at r1. Comments from Reviewable |
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 75.95% 76.13% +0.18%
==========================================
Files 70 70
Lines 8815 8813 -2
Branches 1781 1782 +1
==========================================
+ Hits 6695 6710 +15
+ Misses 1628 1611 -17
Partials 492 492
Continue to review full report at Codecov.
|
GBuella
reviewed
Oct 26, 2017
| pfp, 1, 1, 0, (env_block_size == 0x4000) ? bc_4k : bc)); | ||
|
|
||
| if (env_block_size == 0x4000) | ||
| EXPECT_TRUE(test_pmemfile_stats_match(pfp, 1, 1, 1, bc_4k)); |
There was a problem hiding this comment.
Oh, perhaps we should rename bc_4k -> bc_16k.
Not necessarily in this patch.
| @@ -191,7 +191,8 @@ lseek_seek_data_or_hole(PMEMfilepool *pfp, struct pmemfile_vinode *vinode, | |||
| if (vinode_is_regular_file(vinode)) { | |||
| if (whence == PMEMFILE_SEEK_DATA) { | |||
| offset = lseek_seek_data(pfp, vinode, offset, fsize); | |||
| ASSERT(offset <= fsize); | |||
| if (offset > fsize) | |||
There was a problem hiding this comment.
I'm not sure if this should be offset > fsize or offset >= fsize.
E.g. what should happen with an empty file, should offset == 0 be OK with SEEK_DATA?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is