Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.0 #6085

Merged
merged 280 commits into from
May 13, 2024
Merged

Release 2.1.0 #6085

merged 280 commits into from
May 13, 2024

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented May 10, 2024

This change is Reviewable

janekmi and others added 30 commits January 25, 2024 10:50
Removing the Braille test directory suffix to simplify
manual test reproduction.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
common: Removing the annoying test directory suffix
ERR() macro uses CORE_LOG_ERROR to push mesages to ouputs
Introduce to separate macros to report errors w/ and w/o errno.
test for CORE_LOG_ERROR_WITH_ERRNO

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Disable test until issue pmem#5972 is fixed.
pmem#5972

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Disable test until issue pmem#5974 is fixed.
pmem#5974

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
pmem: disable flag verification until pmem#5979 is fixed
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
…fixed

pmem#5983

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
pmem#5982

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
… fixed

pmem#5981

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Add out_log_va to the white list as it is no longer used in the
release version.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Remove "!..." logic from error message format string.
Use separate argument to either use or not use errno in error message.
Remove non-posix version of util_strerror.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Pmemobj error via ERR() instead of LOG(1,...
- put the primary destination first and the auxiliary second

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
osalyk and others added 11 commits April 15, 2024 08:03
common: add SDS related CORE_LOG_WARNING to core_log_max test
The problem was observed and confirmed only on Ubuntu
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.co
doc: logging information added to manpages (7)
doc: mark old logging as deprecated
common: update CODECOV workflow file
@osalyk osalyk added the sprint goal This pull request is part of the ongoing sprint label May 10, 2024
@osalyk osalyk requested review from grom72 and janekmi May 10, 2024 11:01
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)


ChangeLog line 6 at r2 (raw file):


	This release:
	- ...

It is not needed in the release Changelog or at least it should be a part of the second commit

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


ChangeLog line 6 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

It is not needed in the release Changelog or at least it should be a part of the second commit

You need to prepare space for future releases. I think it should stay here in order not to make another PR later on.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_cancel:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

a discussion (no related file):
Rename the target branch to stable-2.1


@osalyk osalyk changed the base branch from stable-2.1.0 to stable-2.1 May 13, 2024 06:58
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Rename the target branch to stable-2.1

Done.


Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)

a discussion (no related file):

Previously, osalyk (Oksana Sałyk) wrote…

Done.

@osalyk please remove branch stable-2.1.0


a discussion (no related file):
Shall we also modify utils/docker/images/set-images-version.sh?


Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 370 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

@osalyk please remove branch stable-2.1.0

Done.


a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Shall we also modify utils/docker/images/set-images-version.sh?

Done.


Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 366 of 366 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@grom72 grom72 merged commit cd4ad2d into pmem:stable-2.1 May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants