Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: update CODECOV workflow file #6080

Closed
wants to merge 1 commit into from
Closed

common: update CODECOV workflow file #6080

wants to merge 1 commit into from

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented Apr 19, 2024

@osalyk osalyk added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Apr 19, 2024
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)


.github/workflows/scan_coverage.yml line 20 at r1 (raw file):

  OS:           ubuntu
  OS_VER:       22.04
  COVERAGE:     1

I believe when we are ready this toggle has to be dropped as well.


utils/docker/build-CI.sh line 38 at r1 (raw file):

if [[ $MAKE_PKG -eq 0 ]] ; then command="./run-build.sh"; fi
if [[ $MAKE_PKG -eq 1 ]] ; then command="./run-build-package.sh"; fi
if [[ $COVERAGE -eq 1 ]] ; then command="./run-coverage.sh"; fi

You can drop this toggle once you replace what it has been doing excluding the upload step. Namely:

  1. make -j$(nproc) test COVERAGE=1
  2. make -kj2 pcheck-local-quiet TEST_BUILD=debug || true
  3. make -kj2 pycheck TEST_BUILD=debug || true

Or similar. Do we have it right now?


utils/docker/images/Dockerfile.ubuntu-22.04 line 100 at r1 (raw file):

	$MISC_DEPS \
	&& ./install-valgrind.sh ubuntu \
	&& ./download-scripts.sh \

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @janekmi)


.github/workflows/scan_coverage.yml line 20 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I believe when we are ready this toggle has to be dropped as well.

Done.


utils/docker/images/Dockerfile.ubuntu-22.04 line 100 at r1 (raw file):

	$MISC_DEPS \
	&& ./install-valgrind.sh ubuntu \
	&& ./download-scripts.sh \

Done.

@osalyk
Copy link
Contributor Author

osalyk commented May 6, 2024

@osalyk osalyk closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants