Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: ansible_user support in ansible scripts #6055

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Mar 14, 2024

This PR is a replacement for #5955.


This change is Reviewable

szczepax and others added 3 commits March 13, 2024 07:48
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 14, 2024
@grom72 grom72 requested a review from janekmi March 14, 2024 15:51
@grom72 grom72 requested a review from osalyk March 14, 2024 15:51
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (9819db6) to head (9316218).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6055   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         133      133           
  Lines       19563    19563           
  Branches     3261     3261           
=======================================
  Hits        13708    13708           
  Misses       5855     5855           

@janekmi janekmi added this to the 2.1.0 milestone Mar 14, 2024
@grom72 grom72 added build system What Makefiles do and removed sprint goal This pull request is part of the ongoing sprint labels Mar 15, 2024
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 3 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@grom72 grom72 modified the milestones: 2.1.0, 2.1.1 Mar 27, 2024
@janekmi janekmi modified the milestones: 2.1.1, 2.1.0 Mar 27, 2024
@grom72 grom72 modified the milestones: 2.1.0, 2.x Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system What Makefiles do no changelog Add to skip the changelog check on your pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants