Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: remove non-Linux support from all build paths #5941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

common: remove non-Linux support from all build paths #5941

wants to merge 2 commits into from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Nov 27, 2023 •
edited

Remove files and compilation options irrelevant to supported compilation options.

Fixes: #5715

This change is Reviewable

@grom72 grom72 added build system What Makefiles do sprint goal This pull request is part of the ongoing sprint labels Nov 27, 2023
@grom72 grom72 added this to the 2.0.1 milestone Nov 27, 2023
@grom72 grom72 marked this pull request as ready for review November 27, 2023 12:43
@grom72 grom72 added the obsolete-src Obsolete source code label Nov 27, 2023
@grom72 grom72 modified the milestones: 2.0.1, 2.0.2 Nov 28, 2023
@grom72 grom72 removed the sprint goal This pull request is part of the ongoing sprint label Nov 28, 2023
osalyk
osalyk reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 12 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @janekmi)

@osalyk
Copy link
Contributor

osalyk commented Dec 8, 2023

Please rebase.

@janekmi janekmi modified the milestones: 2.1.0, 2.x Feb 8, 2024
@grom72
common: remove non-Linux support from all build paths
e8d1d4d 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72
grom72 commented Mar 21, 2024
View reviewed changes
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: 6 of 13 files reviewed, all discussions resolved (waiting on @janekmi and @osalyk)

grom72
grom72 commented Mar 21, 2024
View reviewed changes
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 12 files at r1, 1 of 7 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@grom72 grom72 requested a review from osalyk March 21, 2024 14:45
osalyk
osalyk approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 7 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (457c61d) to head (d34357a).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5941      +/-   ##
==========================================
- Coverage   70.14%   70.12%   -0.02%     
==========================================
  Files         133      133              
  Lines       19568    19568              
  Branches     3261     3261              
==========================================
- Hits        13726    13723       -3     
- Misses       5842     5845       +3

@grom72 grom72 modified the milestones: 2.x, 2.1.1 Mar 27, 2024
@janekmi janekmi modified the milestones: 2.1.1, 2.1.0 Mar 27, 2024
@grom72 grom72 modified the milestones: 2.1.0, 2.x Mar 28, 2024
@grom72
common: simplification of OS_DIMM flag handling
d34357a 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72
grom72 commented Mar 28, 2024
View reviewed changes
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osalyk osalyk osalyk approved these changes

@janekmi janekmi Awaiting requested review from janekmi

Assignees
No one assigned
Labels
build system What Makefiles do obsolete-src Obsolete source code
Projects
None yet
Milestone
2.x
Development

Successfully merging this pull request may close these issues.

Obsolete makefile sections ifeq ($(OS_KERNEL_NAME),Linux)
3 participants
@grom72 @osalyk @janekmi