Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add statistics verification to obj_pmalloc_mt test #5566

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Mar 30, 2023

Enable statistics in pmalloc mt tests.
Extend diagnostic of some tests like pmalloc, prealloc result verification.


This change is Reviewable

src/test/obj_pmalloc_mt/obj_pmalloc_mt.c Fixed Show fixed Hide fixed
src/test/obj_pmalloc_mt/obj_pmalloc_mt.c Fixed Show fixed Hide fixed
src/test/obj_pmalloc_mt/obj_pmalloc_mt.c Fixed Show fixed Hide fixed
src/test/obj_pmalloc_mt/obj_pmalloc_mt.c Fixed Show fixed Hide fixed
src/test/obj_pmalloc_mt/obj_pmalloc_mt.c Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #5566 (e32965e) into master (7c189da) will increase coverage by 2.02%.
The diff coverage is n/a.

❗ Current head e32965e differs from pull request most recent head b8ed133. Consider uploading reports for the commit b8ed133 to get more accurate results

@@            Coverage Diff             @@
##           master    #5566      +/-   ##
==========================================
+ Coverage   72.25%   74.28%   +2.02%     
==========================================
  Files         145      145              
  Lines       22633    22131     -502     
  Branches     3771     3704      -67     
==========================================
+ Hits        16353    16439      +86     
+ Misses       6280     5692     -588     

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on @github-code-scanning[bot])


src/test/obj_pmalloc_mt/obj_pmalloc_mt.c line 401 at r1 (raw file):

Previously, github-code-scanning[bot] wrote…

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.

Show more details

Done.


src/test/obj_pmalloc_mt/obj_pmalloc_mt.c line 403 at r1 (raw file):

Previously, github-code-scanning[bot] wrote…

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.

Show more details

Done.


src/test/obj_pmalloc_mt/obj_pmalloc_mt.c line 436 at r1 (raw file):

Previously, github-code-scanning[bot] wrote…

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.

Show more details

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on @github-code-scanning[bot])


src/test/obj_pmalloc_mt/obj_pmalloc_mt.c line 394 at r1 (raw file):

Previously, github-code-scanning[bot] wrote…

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.

Show more details

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on @github-code-scanning[bot])


src/test/obj_pmalloc_mt/obj_pmalloc_mt.c line 428 at r1 (raw file):

Previously, github-code-scanning[bot] wrote…

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.

Show more details

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @github-code-scanning[bot] from 5 discussions.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @github-code-scanning[bot])

@grom72 grom72 force-pushed the obj-pmalloc-mt-w-stats branch 3 times, most recently from b1a5691 to f5b38d2 Compare March 31, 2023 11:51
@grom72 grom72 marked this pull request as ready for review March 31, 2023 11:52
Enable statistics in pmalloc mt tests.
Extend missing diagnostic of pmalloc and prealloc
functions calls.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Narrow test iteration to get proper error log file.
Revers logic of test to unblock other tests.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 marked this pull request as draft March 31, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant