Merge pull request #5942 from osalyk/call_stack-usage

common: remove stack_usage.txt from repo
pmem · Nov 28, 2023 · a6d7529 · a6d7529
2 parents 7538b71 + 47db46f
commit a6d7529
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1,558 deletions.
diff --git a/.github/workflows/scan_stack_usage.yml b/.github/workflows/scan_stack_usage.yml
@@ -44,37 +44,10 @@ jobs:
           make
           sudo make install
 
-      - name: Re-build stack_usage.txt
+      - name: Make call stacks
         working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }}
         run: |
           ./make_stack_usage.sh
-          git diff stack_usage.txt > stack_usage_diff.txt
-
-      - name: Upload stack_usage.txt and its diff
-        uses: actions/upload-artifact@v3
-        with:
-          name: stack_usage
-          path: |
-            ${{ env.CALL_STACKS_TOOLS_PATH }}/stack_usage.txt
-            ${{ env.CALL_STACKS_TOOLS_PATH }}/stack_usage_diff.txt
-
-      # XXX A per-function stack usage fluctuates a lot depending on
-      # software configuration rendering its contents basically unfit for
-      # being validated. If we decide to keep it in the repo, we must agree
-      # on a golden software configuration on which it will be generated
-      # and be prepared for regular false positives whenever an update comes.
-      - name: Validate stack_usage.txt
-        working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }}
-        run: |
-          git status -s stack_usage.txt
-          if [ ! -z "$(git status -s stack_usage.txt)" ]; then
-            cat stack_usage_diff.txt
-            # exit 1 # XXX
-          fi
-
-      - name: Generate call stacks
-        working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }}
-        run: |
           ./make_api.sh
           ./make_extra.py
           ./make_cflow.sh
@@ -103,11 +76,13 @@ jobs:
           done
           rm -f ${{ env.TEMP }}
 
-      - name: Upload call_stacks_filtered.(json|txt)
+      - name: Upload artifacts
         uses: actions/upload-artifact@v3
         with:
-          name: ${{ env.FILTERED_PREFIX }}
-          path: ${{ env.CALL_STACKS_TOOLS_PATH }}/${{ env.FILTERED_PREFIX }}.*
+          name: call_stacks_data
+          path: |
+            ${{ env.CALL_STACKS_TOOLS_PATH }}/stack_usage.txt
+            ${{ env.CALL_STACKS_TOOLS_PATH }}/${{ env.FILTERED_PREFIX }}.*
 
       - name: Make sure no call stack falls above the limit
         working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }}

diff --git a/utils/call_stacks_analysis/.gitignore b/utils/call_stacks_analysis/.gitignore
@@ -1,6 +1,5 @@
 *.err
 *.json
 *.txt
-!stack_usage.txt
 !white_list.json
 !examples/*