common: remove redundant errno assignment

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
pmem · Oct 24, 2023 · 1210c10 · 1210c10
1 parent fbb9d96
commit 1210c10
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/src/libpmem2/deep_flush_linux.c b/src/libpmem2/deep_flush_linux.c
@@ -37,7 +37,6 @@ pmem2_deep_flush_write(unsigned region_id)
 	deep_flush_path = Malloc(PATH_MAX * sizeof(char));
 	if (deep_flush_path == NULL) {
 		ERR("!Malloc");
-		errno = ENOMEM;
 		ret = PMEM2_E_ERRNO;
 		goto end;
 	}

diff --git a/src/libpmem2/pmem2_utils_linux.c b/src/libpmem2/pmem2_utils_linux.c
@@ -44,7 +44,6 @@ pmem2_get_type_from_stat(const os_stat_t *st, enum pmem2_file_type *type)
 
 	spath = Malloc(PATH_MAX * sizeof(char));
 	if (spath == NULL) {
-		errno = ENOMEM;
 		ERR("!Malloc");
 		return PMEM2_E_ERRNO;
 	}
@@ -65,7 +64,6 @@ pmem2_get_type_from_stat(const os_stat_t *st, enum pmem2_file_type *type)
 
 	npath = Malloc(PATH_MAX * sizeof(char));
 	if (npath == NULL) {
-		errno = ENOMEM;
 		ERR("!Malloc");
 		ret = PMEM2_E_ERRNO;
 		goto end;
@@ -88,10 +86,10 @@ pmem2_get_type_from_stat(const os_stat_t *st, enum pmem2_file_type *type)
 	*type = PMEM2_FTYPE_DEVDAX;
 
 end:
-	if (spath)
-		Free(spath);
 	if (npath)
 		Free(npath);
+	if (spath)
+		Free(spath);
 
 	return ret;
 }
diff --git a/src/libpmem2/region_namespace_ndctl.c b/src/libpmem2/region_namespace_ndctl.c
@@ -37,7 +37,6 @@ ndctl_match_devdax(dev_t st_rdev, const char *devname)
 
 	path = Malloc(PATH_MAX * sizeof(char));
 	if (path == NULL) {
-		errno = ENOMEM;
 		ERR("!Malloc");
 		return PMEM2_E_ERRNO;
 
@@ -89,7 +88,6 @@ ndctl_match_fsdax(dev_t st_dev, const char *devname)
 
 	path = Malloc(PATH_MAX * sizeof(char));
 	if (path == NULL) {
-		errno = ENOMEM;
 		ERR("!Malloc");
 		return PMEM2_E_ERRNO;
 	}
@@ -148,7 +146,6 @@ ndctl_match_fsdax(dev_t st_dev, const char *devname)
 	}
 
 	LOG(4, "found matching device: %s", path);
-
 end:
 	Free(path);