Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance hole property in Pie Chart for variable slice radii #6769

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Enhance hole property in Pie Chart for variable slice radii #6769

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4390811
Enhance `hole` property in Pie Chart for variable slice radii
barrymichaeldoyle Nov 2, 2023
c04f20b
Create 6769_add.md
barrymichaeldoyle Nov 2, 2023
3731007
Update attributes.js to add arrayOk to pie `hole` attribute
barrymichaeldoyle Nov 2, 2023
d2c0a7d
Update plot.js to cater for all cases of `.hole`
barrymichaeldoyle Nov 2, 2023
ec0dcb3
updated plot-schema diff
barrymichaeldoyle Nov 3, 2023
6550f3f
updated plot-schema diff
barrymichaeldoyle Nov 3, 2023
219e208
Merge branch 'plotly:master' into patch-1
barrymichaeldoyle Nov 7, 2023
4ac61a4
applied PR changes requested and updated plot-schema.json
barrymichaeldoyle Nov 8, 2023
c289f2c
applied lib array checks where necessary
barrymichaeldoyle Nov 11, 2023
d6fe132
aplied special case check for when hole is array
barrymichaeldoyle Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/6769_add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Enhance `hole` property in Pie Chart for variable slice radii [[#6769](https://github.com/plotly/plotly.js/pull/6769)]
1 change: 1 addition & 0 deletions src/traces/pie/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ module.exports = {
max: 1,
dflt: 0,
editType: 'calc',
arrayOk: true,
description: [
'Sets the fraction of the radius to cut out of the pie.',
'Use this to make a donut chart.'
Expand Down
8 changes: 4 additions & 4 deletions src/traces/pie/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function plot(gd, cdModule) {
pt.largeArc + (cw ? ' 1 ' : ' 0 ') + dx + ',' + dy;
}

var hole = trace.hole;
var hole = trace.hole[i] || trace.hole;
barrymichaeldoyle marked this conversation as resolved.
Show resolved Hide resolved
if(pt.v === cd0.vTotal) { // 100% fails bcs arc start and end are identical
var outerCircle = 'M' + (cx + pt.px0[0]) + ',' + (cy + pt.px0[1]) +
arc(pt.px0, pt.pxmid, true, 1) +
Expand Down Expand Up @@ -731,7 +731,7 @@ function calcMaxHalfSize(a, halfAngle, r, ring) {
}

function getInscribedRadiusFraction(pt, cd0) {
if(pt.v === cd0.vTotal && !cd0.trace.hole) return 1;// special case of 100% with no hole
if(pt.v === cd0.vTotal && !(cd0.trace.hole[0] || cd0.trace.hole)) return 1;// special case of 100% with no hole
barrymichaeldoyle marked this conversation as resolved.
Show resolved Hide resolved

return Math.min(1 / (1 + 1 / Math.sin(pt.halfangle)), pt.ring / 2);
}
Expand Down Expand Up @@ -761,7 +761,7 @@ function positionTitleInside(cd0) {
return {
x: cd0.cx,
y: cd0.cy,
scale: cd0.trace.hole * cd0.r * 2 / textDiameter,
scale: (cd0.trace.hole[0] || cd0.trace.hole) * cd0.r * 2 / textDiameter,
barrymichaeldoyle marked this conversation as resolved.
Show resolved Hide resolved
tx: 0,
ty: - cd0.titleBox.height / 2 + cd0.trace.title.font.size
};
Expand Down Expand Up @@ -1089,7 +1089,7 @@ function setCoords(cd) {
cdi.largeArc = (cdi.v > cd0.vTotal / 2) ? 1 : 0;

cdi.halfangle = Math.PI * Math.min(cdi.v / cd0.vTotal, 0.5);
cdi.ring = 1 - trace.hole;
cdi.ring = 1 - (trace.hole[i] || trace.hole);
barrymichaeldoyle marked this conversation as resolved.
Show resolved Hide resolved
cdi.rInscribed = getInscribedRadiusFraction(cdi, cd0);
}
}
Expand Down
1 change: 1 addition & 0 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42615,6 +42615,7 @@
}
},
"hole": {
"arrayOk": true,
"description": "Sets the fraction of the radius to cut out of the pie. Use this to make a donut chart.",
"dflt": 0,
"editType": "calc",
Expand Down