Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick implementation of most of ggraph/ggforce #1326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Aug 22, 2018

TODO:

  • Converters for ggforce's GeomMarkCircle/GeomMarkEllipsis/GeomMarkHull
  • Converter for ggraph's GeomAxisHive (path + text?). For example, see https://github.com/thomasp85/ggraph/blob/8d23845/R/geom_axis_hive.R#L123-L142
  • Add relevant key attributes.
  • Throw warnings/pointers to issues when lack of plotly.js support for color/width arrays is relevant (perhaps this should be done at the geom2trace() level).
  • Catch cases where we need to incorporate geom params into the drawing logic?
  • Tests!

@gvdr
Copy link

gvdr commented Jan 23, 2020

Was this PR ever considered? What's the situation now?

@cpsievert
Copy link
Collaborator Author

cpsievert commented Nov 2, 2021

@danton267 would you mind filing an issue requesting this feature? Having some {ggraph}/{ggforce} support would have a much higher ROI compared to some of the other extensions you've requested https://github.com/plotly/plotly.R/issues/created_by/danton267

@moutikabdessabour
Copy link
Contributor

@cpsievert I will happily work on some of the geoms

@cpsievert cpsievert mentioned this pull request Nov 2, 2021
26 tasks
@cpsievert
Copy link
Collaborator Author

@moutikabdessabour it'd be great if you could also look into converting {ggraph} based treemaps, so that we can avoid the potential licensing issues with converting {treemapify} #2051

@moutikabdessabour
Copy link
Contributor

moutikabdessabour commented Nov 2, 2021

@cpsievert currently implementing ggraph's GeomAxisHive. Once I will finish I will move forward to ggraph's treemaps

@moutikabdessabour

This comment has been minimized.

@moutikabdessabour
Copy link
Contributor

moutikabdessabour commented Nov 3, 2021

I implemented the ggraph's {treemap} this is the one that's similar to {treemapify} output.
Screen Shot 2021-11-03 at 4 25 20 AM

Do you think I should go forward and implement all the examples found here?? https://www.data-imaginist.com/2017/ggraph-introduction-layouts/

Now all the hierarchical plots are supported.

EDIT:

I just noticed that you had some of the geoms implemented in this PR. so ggraph treemaps are supported in this PR too

EDIT 2:
I managed to get the desired output for ggraph::geom_axis_hive. How can I push the changes? or do you want me to paste the code here.

Screen Shot 2021-11-03 at 6 25 47 AM

Edit 3:

Managed to implement GeomMarkCircle
Screen Shot 2021-11-03 at 7 40 07 AM

I was able to implement all the ggforce geoms you put in the first comment.

@cpsievert how would I convert mm to px in plotly? thanks again for your time.

@cassandraxmah
Copy link

Hello @moutikabdessabour @cpsievert ! Thanks for your work - I am new to posting GitHub issues.

Out of the ggforce package, is it possible to implement the geom_GeomPathInterpolate() so that the geom_link2() will plot?
Thank you! And any workarounds appreciated :)

@jamesdalg
Copy link

Just want to put in my two cents that this would be an incredible addition if it somehow passes checks one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants