Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open/copy target in object browser widget. #5944

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robgietema
Copy link
Member

No description provided.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 9c80c1f
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/660c1a7925580100082ec313

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 9c80c1f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/660c1a7908975900082c2eaf

@ichim-david
Copy link
Sponsor Member

ichim-david commented Apr 3, 2024

link-over
Looking at this screenshot that I took of the feature,
@robgietema I suggest the following:

  • remove the title before the link, it's duplicated and doesn't serve a better purpose than the linked text that follows
    it especially when you have an external link where you get the svg with the external icon.
  • I think a button would be better for the copy link action, right now I feel it needs at a minimum the css pointer cursor added
  • You don't really have any indicator of popup functionality and it's not keyboard accessible but maybe you envision this only as a helper for editors who know that they need this

EDIT:
This is an opinion of mine and not a review, feel free todo what you want with it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants