New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed A11y Video Block Issue #5732
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for plone-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/volto/src/components/manage/Blocks/Video/View.test.jsx
Outdated
Show resolved
Hide resolved
…fixA11yVideoBlockIssue
…fixA11yVideoBlockIssue
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Just for the Record , some Tests are flaky. Idid nothing to the actual code, just changed the News fragment. Suddenly all Checks pass ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News is good, but the rest needs review by a core contributor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @ichim-david could you give your blessing here?
@Molochem @sneridagh it's a small improvement from "Group main" to "Play Video". I would rather say something along the lines "Video embed placeholder image". All of this could be improvement with other tickets but I'm a bit -1 on this idea because you don't Play video |
@Molochem @sneridagh |
fixes #5731
Fixed the missing aira-label on Video-Blocks
It seems a bit hacky, and also im not sure about the Message Content. Suggestions are welcome.