Fixed creation of both a slate block and a (proper) image block on pasting image directly from clipboard #5701
Conversation
…sting an image directly from the clipboard in a slate block
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
|
|
||
| return ( | ||
| <span {...attributes} style={{ display: 'inline-block' }}> | ||
| {children} | ||
| <img alt="" src={element.url} style={style} /> |
There was a problem hiding this comment.
@AnshulKahar2729 We can't do this. This is not the way to fix this issue. We have to dig deeper and find why it's emitting the slate image (which we don't want) and make that it does not emit it. By removing the markup for the slate image is not an acceptable "fix".
Do you agree with me, right?
There was a problem hiding this comment.
Ok, I got the problem, we need to fix the function which creates extra block rather than removing it manually.
|
is this issue still open #5701 @sneridagh |
|
@saloni0419 please read and follow Contributing to Plone and First-time contributors, especially Things not to do. Using your super power of observation, you may see that the green "Open" icon reflects its status, and that by virtue of its URL and the "Pull requests" tab being selected, this is a pull request, not an issue. See GitHub docs. |
|
@AnshulKahar2729 I am closing this pull request, as Victor mentioned this is not as easy as removing the image insertion from Slate. I suggest you study the problem more deeply and raise a pull request only if you've solved it and your work passes the code quality and testing commands. |
Fixes #5697
Description : Earlier on the pasting the images in the blocks, rendering two images on the same time.