Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static resources (JS, CSS), Mockup Patterns and JQuery #1275

Draft
wants to merge 11 commits into
base: 6.0
Choose a base branch
from

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Jul 22, 2022

How to create a theme to hold the static resources?
Where to put the files?
How to apply / register resources?
I've heard about module federation, does this affect me?
I've heard about Mockup patterns? What's the purpose of patterns? What's about JQuery?

@netlify
Copy link

netlify bot commented Jul 22, 2022

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 6741186
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/662f4dad750b5a0009737fc7
😎 Deploy Preview https://deploy-preview-1275--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ksuess
Copy link
Member Author

ksuess commented Jul 22, 2022

If you read this and think this is your topic: Feel free to take over the PR!

@ksuess ksuess added this to the Plone 6.0 milestone Jul 22, 2022
@MrTango MrTango self-assigned this Aug 29, 2022
@petschki
Copy link
Member

petschki commented Jul 2, 2023

should this be rebased to 6.0 ? I saw some other classic-ui PRs based on 6-dev

@stevepiercy
Copy link
Contributor

The current default branch is 6.0. 6-dev was the previous default. PRs should be made against 6.0 and rebased on it or merge 6.0 into the PR branch.

@petschki petschki changed the base branch from 6-dev to 6.0 July 2, 2023 16:18
@petschki
Copy link
Member

@stevepiercy I just saw, that the checked out documentation branch in buildout.coredev is 6-devhttps://github.com/plone/buildout.coredev/blob/6.0/sources.cfg#L31 ... shall we change it?

@stevepiercy
Copy link
Contributor

@stevepiercy I just saw, that the checked out documentation branch in buildout.coredev is 6-devhttps://github.com/plone/buildout.coredev/blob/6.0/sources.cfg#L31 ... shall we change it?

Um... I don't really know. I think the first question is, "Why does coredev check out docs?" It looks like @jensens added it, but I don't understand why.

If there is a purpose for checking out docs, then it should be updated to the currently developed branch.

@stevepiercy
Copy link
Contributor

@plone/classicui-team let's move this PR forward. What needs to be done?

@stevepiercy
Copy link
Contributor

@petschki @jensens @MrTango @ksuess what's the status of this PR? Should it be saved, completed, or closed as "won't fix"?

I think that the content in mockup-patterns.md should be merged into mockup.md.

@jensens
Copy link
Sponsor Member

jensens commented Apr 29, 2024

+1 for merging additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants