add proxy #473
Open
add proxy #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something somebody still wants to try and push forward...? |
|
@SethTisue I completely forgot I wrote this. Lemme review it for sanity :-) |
|
Okay updated |
wsargent
commented
Aug 12, 2021
| import java.util.Objects; | ||
| import java.util.Optional; | ||
|
|
||
| public class DefaultWSProxyServer implements WSProxyServer { |
There was a problem hiding this comment.
Add a proxy server implementation
wsargent
commented
Aug 12, 2021
| @@ -243,6 +240,15 @@ public StandaloneAhcWSRequest setContentType(String contentType) { | |||
| return addHeader(CONTENT_TYPE.toString(), contentType); | |||
| } | |||
|
|
|||
| @Override | |||
| public StandaloneWSRequest setProxyServer(WSProxyServer proxyServer) { | |||
wsargent
commented
Aug 12, 2021
| return builder.build(); | ||
| } | ||
|
|
||
| private ProxyServer createProxy(WSProxyServer proxyServer) { |
wsargent
commented
Aug 12, 2021
| * @param proxyServer the proxy server | ||
| * @return the modified WSRequest | ||
| */ | ||
| StandaloneWSRequest setProxyServer(WSProxyServer proxyServer); |
wsargent
commented
Aug 12, 2021
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| public interface WSProxyServer { |
There was a problem hiding this comment.
WSProxyServer interface
|
Yay! Now, who wants to review this...? |
|
I don't even know who's committer on play-ws now. |
|
(I'd also be willing to just shrug and hit "merge" myself if no reviewers appear and if you believe the change to be safe.) |
|
@wsargent can you please rebase? Thanks! |
|
@mkurz done! |
|
@wsargent CI complaining:
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Purpose