Added tests to format value classes #1041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levinson
force-pushed
the
value-class-scala3-compile-bug
branch
from
09730f7
to
627ffe2
Compare
cchantep
reviewed
May 20, 2024
| @@ -749,5 +751,19 @@ class JsonExtensionSpec extends AnyWordSpec with Matchers { | |||
| formatter.reads(Json.obj("props" -> JsNull)).mustEqual(JsSuccess(Optional(None))) | |||
| formatter.reads(Json.obj("props" -> Some("foo"))).mustEqual(JsSuccess(Optional(Some("foo")))) | |||
| } | |||
| "format value classes" in { | |||
There was a problem hiding this comment.
Suggested change
| "format value classes" in { | |
| "format value classes" in { |
| implicit val userIdFmt: Format[UserId] = Json.format[UserId] | ||
| val userId = UserId(12345) | ||
| val serialized = Json.stringify(Json.toJson(userId)) | ||
| serialized.mustEqual("""{"id":12345}""") |
There was a problem hiding this comment.
Suggested change
| serialized.mustEqual("""{"id":12345}""") | |
| serialized.mustEqual("""{"id":12345}""") |
| serialized.mustEqual("""{"id":12345}""") | ||
| Json.fromJson[UserId](Json.parse(serialized)).mustEqual(JsSuccess(userId)) | ||
| } | ||
| "format value classes with value format" in { |
There was a problem hiding this comment.
Suggested change
| "format value classes with value format" in { | |
| "format value classes with value format" in { |
| implicit val userIdFmt: Format[UserId] = Json.valueFormat[UserId] | ||
| val userId = UserId(12345) | ||
| val serialized = Json.stringify(Json.toJson(userId)) | ||
| serialized.mustEqual("""12345""") |
There was a problem hiding this comment.
Suggested change
| serialized.mustEqual("""12345""") | |
| serialized.mustEqual("""12345""") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
This PR demonstrates #1011. The Json.format[UserId] fails to compile with Scala 3: