-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples mobile fixes #6335
Examples mobile fixes #6335
Conversation
That would possibly have a negative performance impact on fragment limited examples. But considering there is per example control, we can adjust it as needed. Is there a good way to make the Controls panel less wide so that you can see the example you're adjusted on the side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I could try but I feel like on smaller screens more controls will overflow to the next line |
@mvaligursky made the controls panel shorter since its scrollable so you can see more of the screen |
Great solution! Merge away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the polish here - awesome!
How does UI look on high DPI screens, like retina Macs? |
* fixed code editor for mobile * split up components of code editors into separate classes * updated device pixel ratio to use of window (capped at 2) * fixed gizmo sizing for mobile * updated gizmo jsdoc * rerender code editor once tokenizer patched * removed unused variable * made controls panel smaller for mobile * disable min height when not collapsed for controls
Fixes #3991
Fixes #5215
Preview
Code editor
Scrollable & Smaller controls
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.