Gizmo cleanup and bug fixes #6323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Eastcott <will@playcanvas.com>
willeastcott
approved these changes
Apr 30, 2024
|
There's no public API changes with this PR, right? |
No it was just the calculateTris which was removed |
slimbuck
pushed a commit
to slimbuck/engine
that referenced
this pull request
May 20, 2024
* WIP: reworking calcPoint code * fixed ray and plane intersection direction issue * WIP calcPoint cleanup for gizmo * split up different point calculatoin into branches in calcPoint * removed unused point rotation code * extracted scale and rotation calcPoint into their own classes * removed excess tmp vector * extracted out project to line code * updated normal calc code * cleaned up rotation facing calculation * updated lighting in example * updated facing epsilon to threshold * modified base class calcPoint * fixed gizmo local rotation when orthographic * removed unused variables in gizmo-transform and renamed internal properties * made sure to update mesh materials with new colorAlpha * renamed calcPoint * reused same ray and plane objects for _screenToPoint * removed extra variables created * added instruction keybinds and maintained coordspace when switching gizmos * extracted triangles directly from geometry * moved tris generation to inside geometry * Update src/extras/gizmo/rotate-gizmo.js Co-authored-by: Will Eastcott <will@playcanvas.com> * cleaned up comments and variables * space refactor * moved calculateTris back into tri data class * fixed linting issue * fixed scale invariant for gizmo and set device maxPixelRatio * removed unused code --------- Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6262
calcPointinto separate overloads for each subclass (and renamed toscreenToPointcolorAlphaMeshTriDataclass to extract triangles from geometry (moved tri extraction to geometry and renamed class toTriData)Preview