Small refactor to separate composition update from framegraph building (

#6333) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
playcanvas · May 1, 2024 · a956aca · a956aca
1 parent 5a34e87
commit a956aca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/framework/app-base.js b/src/framework/app-base.js
@@ -1195,6 +1195,10 @@ class AppBase extends EventHandler {
     // render a layer composition
     renderComposition(layerComposition) {
         DebugGraphics.clearGpuMarkers();
+
+        // update composition, cull everything, assign atlas slots for clustered lighting
+        this.renderer.update(layerComposition);
+
         this.renderer.buildFrameGraph(this.frameGraph, layerComposition);
         this.frameGraph.render(this.graphicsDevice);
     }

diff --git a/src/scene/renderer/forward-renderer.js b/src/scene/renderer/forward-renderer.js
@@ -814,9 +814,6 @@ class ForwardRenderer extends Renderer {
         const scene = this.scene;
         frameGraph.reset();
 
-        // update composition, cull everything, assign atlas slots for clustered lighting
-        this.update(layerComposition);
-
         if (scene.clusteredLightingEnabled) {
 
             // clustered lighting passes