v3-channels: use MPD supplied song data instead of reading it manually #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason really not to reuse the MPD::Song objects which already contain the data, which was pre-read and stored by MPD. For filepaths, a new method is introduced which fetches a MPD::Song object for the specified path, and constructs a Song instance.
Closed
|
Though I like it, this is a bit heavy to toss into the Maybe just wait until |
|
I agree, but the changes were made on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason really not to reuse the MPD::Song objects which already contain the data, which was pre-read and stored by MPD.
For filepaths, a new method is introduced which fetches a MPD::Song object for the specified path, and constructs a Song instance.