Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd.queue.first -> mpd.current_song #340

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

mpd.queue.first -> mpd.current_song #340

wants to merge 1 commit into from

Conversation

archseer
Copy link

Beats grabbing the entire queue. Besides, if consume is not enabled, mpd.queue.first doesn't point to the currently playing song, but the first in the queue/playlist.

Beats grabbing the entire queue. Besides, if consume is not enabled, mpd.queue.first doesn't point to the currently playing song, but the first in the queue/playlist.
@archseer archseer mentioned this pull request Sep 23, 2013
@holman
Copy link
Member

holman commented Sep 23, 2013

current_song only works if music is playing, yeah? I think there was a specific reason I picked first off the queue… mostly for that edge case. Now, that shouldn't really happen in Play, but it's a possibility. Also, consume should be on the whole time, anyway.

Nice to see you in on this project, by the way! :)

@archseer
Copy link
Author

@holman not as far as I can tell, I tried pausing or stopping, but it still returns the correct one. The specs say "Displays the song info of the current song (same song that is identified in status).", and in status "song: playlist song number of the current song stopped on or playing", so it should return the correct one regardless. It will return nil however, if the queue is empty.

No problem, as I've said, ruby-mpd was written for a play inspired project, so I'm looking for ways to contribute! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants