PoC: keep log_comment metadata in ClickHouse queries #3702
Conversation
| def init(_opts), do: nil | ||
|
|
||
| def call(conn, _) do | ||
| ClickhouseRepo.set_context(%{request_path: conn.request_path}) |
There was a problem hiding this comment.
Depending on what's more suitable, we can either go with route with placeholders, or full request path
| @@ -15,6 +15,8 @@ defmodule Plausible.Stats.Query do | |||
| @type t :: %__MODULE__{} | |||
|
|
|||
| def from(site, params) do | |||
| Plausible.ClickhouseRepo.set_context(params) | |||
There was a problem hiding this comment.
Not a great idea perhaps, since params is external and at this point, untrusted, input.
We could probably sanitize it a bit, or serialize the result of Map.from_struct(query) but there's a bit more work required, depending on what is really useful to keep - just flagging it.
Similarly, there's more places when the %Query{} is updated - some changes are made via this module, but others operate on the struct directly, so there's probably a good chunk of sensible info missing unless we keep track of it too. Maybe a good opportunity to make sure the struct is opaque and is never changed outside of its API.
Iteration on #3699
@macobo feel free to take it from here, if this is what you were looking for. There's certainly docs and tests missing 😜
Mind you, neither
IngestRepo,ImportDeletionReponorAsyncInsertRepoare instrumented but I guess it's reads that you're interested in.