Alter Compile function to work with M2 >=2.1 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release of Magento 2.1.0 removed setup:di:compile-multi-tenant. As we haven't initiated Magento in this script we can't check its version number. To get round this I've put in some error handling. First we try multi-tenant complilation and if that fails we catch as we are greater or equal to 2.1 and use setup:di:compile.
|
I had to call |
|
even though that echo's to the console - didn't the catch block also fire? |
|
thinking about it - it was a runtime exception on my set-up but maybe that's too specific - maybe the catch block should just be for a standard exception... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of Magento 2.1.0 removed setup:di:compile-multi-tenant. As we haven't initiated Magento in this script we can't check its version number. To get round this I've put in some error handling. First we try multi-tenant complilation and if that fails we catch as we are greater or equal to 2.1 and use setup:di:compile.