Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break build if any of ADMIN_* variables is not filled #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Break build if any of ADMIN_* variables is not filled #10

wants to merge 1 commit into from

Conversation

satknightn
Copy link
Contributor

  • do not install Magento if any of ADMIN_* variables is not set
  • do not update Magento admin credentials and path if any of ADMIN_* variables is not set
  • add comments to some methods

@yurii-RW
Break build if any of ADMIN_* variables is not filled
007c677 
- do not install Magento if any of ADMIN_* variables is not set
- do not update Magento admin credentials and path if any of ADMIN_* variables is not set
- add comments to some methods
@gmoigneu
Copy link
Contributor

I'll check with everyone that the doc is up to date before merging it.

7ochem
7ochem reviewed Jul 26, 2016
View reviewed changes
Platformsh.php
--admin-password=$this->adminPassword";

--backend-frontname={$this->adminVariables['ADMIN_URL']} \
--admin-user={$this->adminVariables['ADMIN_USERNAME']} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be great if shell argument escaping would be applied here. http://php.net/escapeshellarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@satknightn @gmoigneu @7ochem @yurii-RW