Fixes issue plantuml#1746: (timing diagram) message labels ignore default style #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for issue #1746 that I mentioned in comments there.
Other than the new font settings for the TimingDiagram arrow in the plantuml.skin and rose.skin files, this change is isolated to just the TimeArrow.java file. I just had to make the textLabel get its style in a similar manner to how the text in the TimeConstraint file got its style, mostly changing the getFontConfiguration(..) method to use the same steps.
The only change after my comments in the issue discussion is that I took away the 2 space padding I had mentioned adding because I decided I didn't know all the implications of that extra padding for all rotations of the message arrow, and it wasn't part of the issue to begin with (just an esthetic preference I had). In other words, this change is now only about resolving the issue with the user configurability of the message font (style, size, color).
Let me know if you have any questions, need any changes made, etc. All the images I thought to share here are in the issue discussion.
Regards,
Jim Nelson