Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some non-regression tests for certain issues #1772

Merged
merged 2 commits into from
May 8, 2024

Conversation

travkin79
Copy link
Contributor

Test cases for issues #1580, #1735, #1768, and #1491.

Unfortunately, it's not that easy to make regression tests since style and layout details may influence the resulting SVG / PNG images. Thus, these are non-regression tests.

@arnaudroques
Copy link
Contributor

Thanks for those tests.
However, it is not clear to me why build.gradle.kts should be changed.
Could you tell us more about this? Thanks!

@travkin79
Copy link
Contributor Author

Actually changing build.gradle.kts is not necessary for this PR.
I'm working on some other tests that are reading *.puml files in the test folder and I thought it might be useful to add *.puml files to the test folder for additional tests, that's why added this change. But of course, we can omit modifying build.gradle.kts as long as no test actually reads *.puml files from the test folder.

@arnaudroques arnaudroques merged commit ec686a2 into plantuml:master May 8, 2024
9 checks passed
@travkin79
Copy link
Contributor Author

Thank you, @arnaudroques.

@travkin79 travkin79 deleted the patch/tests branch May 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants