Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build macOS and Windows native images #1362

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

ggrossetie
Copy link
Contributor

What I Did

  • Enable cross OS cache (to share cache between ubuntu-latest, windows-latest and macos-latest)
  • Replace manual install steps of GraalVM by graalvm/setup-graalvm@v1 (official GitHub Actions to install GraalVM)
  • Enable matrix job to build macOS, Windows and Linux native images using the same steps
  • Add plantuml-darwin-amd64-* and plantuml-win-amd64-*.exe in the release directory

@arnaudroques arnaudroques merged commit fd587ce into plantuml:master Mar 26, 2023
@arnaudroques
Copy link
Contributor

Thanks for your contribution.
However, we have a minor regression: in version title, we now have a strange ~v whereas we use to have the beta version of the snapshot (something like v1.2023.6beta1 )
Any idea why?
Could you restore it?
Thanks again!

@ggrossetie
Copy link
Contributor Author

ggrossetie commented Mar 26, 2023

I changed POM_VERSION to RELEASE_VERSION, it's probably related. I will take a closer look.

@The-Lum
Copy link
Collaborator

The-Lum commented Mar 26, 2023

Hi all,
I can fixed that tomorrow.
Regards.

@arnaudroques
Copy link
Contributor

Hi all, I can fixed that tomorrow. Regards.

Thanks!
Actually, Guillaume has partially fixed it.

@ggrossetie You can leave it like this, we'll take the point. Thanks again for your work, you did a great job!

@The-Lum
Copy link
Collaborator

The-Lum commented Mar 27, 2023

Hi all,

That is now fully fixed (with #1363)
Thanks @ggrossetie.

But the mean question is now:

  • Is it necessary or not to change all POM_VERSION on RELEASE_VERSION?
    Especially on CI.yml file.

To debate...
Regards.

@ggrossetie
Copy link
Contributor Author

Is it necessary or not to change all POM_VERSION on RELEASE_VERSION?

The goal was to use this value in other commands/scripts that's why I moved it outside release.sh and release-snapshot.sh:

echo "release_version=$(gradle properties -q | grep "version:" | awk '{print $2}')" >> $GITHUB_OUTPUT

Since it relies on Gradle we cannot move this step in workflow_config unless we install Gradle or find another way to get this value.

@ggrossetie
Copy link
Contributor Author

ggrossetie commented Mar 27, 2023

Is it necessary or not to change all POM_VERSION on RELEASE_VERSION?

I guess I didn't understand your question. I'm not familiar enough with the release process to know if pom_version is strictly equals to $(gradle properties -q | grep "version:" | awk '{print $2}'). If that's the case then we could simplify things and use the same variable everywhere.

Naming wise, I prefer release_version instead of pom_version since it's more ubiquitous.

@ggrossetie ggrossetie deleted the native-images-macos-win branch February 11, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants