Fix cast logic #174
Merged
Fix cast logic #174
+1,053
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
commented
Apr 25, 2024
mattrobenolt
force-pushed
the
fix-cast
branch
2 times, most recently
from
d014905
to
ae92750
Compare
There's a lot to unpack here, but the tl;dr is to refer to the charset ultimately to determine if the data is UTF8, if it is, we can decode it to a UTF8 string. This fixes behavior around CHAR/TEXT fields with a binary collation, being surfaces as BINARY/BLOB types by MySQL. For all intents and purposes, BLOB/BINARY/CHAR/TEXT are all effectively identical and interchangeable, the only differentiator is their charset. Either they are a UTF-8 charset, or a binary charset or some other charset. Fixes #169
mattrobenolt
force-pushed
the
fix-cast
branch
2 times, most recently
from
8b95a38
to
b5c7ed8
Compare
mattrobenolt
commented
Apr 25, 2024
mattrobenolt
commented
Apr 25, 2024
__tests__/index.test.ts
Outdated
| @@ -13,6 +16,13 @@ const config = { | |||
| fetch | |||
| } | |||
|
|
|||
| function uint8ArrayFromHex(text: string): Uint8Array { | |||
There was a problem hiding this comment.
This helper was nice becuase it makes it easier to copy/paste the hex output from mysql CLI for it's rendering of binary data. Figured I'd like to have a source of truth to copy/paste from rather than hand writing each byte in a Uint8Array.
mattrobenolt
commented
Apr 25, 2024
mattrobenolt
commented
Apr 25, 2024
|
@ayrton I can't approve your changes since I created the PR, but everything I brought up was addressed, looks good to me. |
ayrton
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot to unpack here, but the tl;dr is to refer to the charset ultimately to determine if the data is binary, or non-binary which is always UTF-8.
This fixes behavior around CHAR/TEXT fields with a binary collation, being surfaces as BINARY/BLOB types by MySQL.
For all intents and purposes, BLOB/BINARY/CHAR/TEXT are all effectively identical and interchangeable, the only differentiator is their charset. Either they are a binary charset, or they are encoded as UTF-8.
This behavior seems to differ slightly from vanilla MySQL and is specific to potentially a bug in Vitess, but this default is much safer for future proofing if we fix things there.
Fixes #169 #171