Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated Biomass Proxy Workflows example notebook #306

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

teije01
Copy link

@teije01 teije01 commented Jul 13, 2023

Updated the biomass proxy workflow notebook on which the biomass proxy workflow example is based.
It features:

  • obtaining credentials via keyring
  • plotting grids from a bucket using rasterio
  • retrieving results and creating a pandas DataFrame from the result statistics

Internal ref: CONTENT-682

@teije01
Copy link
Author

teije01 commented Jul 13, 2023

Should I delete the notebook under jupyter-notebooks/subscriptions_api_tutorial/Biomass_Proxy_PV_Subs_Ohio.ipynb?

Copy link
Contributor

@mkshah605 mkshah605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!!

A couple small things (that may already have been there before my I'm just noticing them)

  • Whenever we mention Google Cloud, can we ensure that those two words are capitalized? There are a lot of different versions of this currently, with regards to capitalization

  • In cell 12 (under "Inspect Results) can we print out only a subset of results so that the printed results don't take up as much space in the final notebook? Printing out the first ~5 or so should be okay, with an added note that there are more results, we are only displaying 5 (as an example).

Otherwise, looks great. Thanks so much!!

@teije01
Copy link
Author

teije01 commented Jul 20, 2023

I've updated the merge request with your two comments:

  • All "Google Cloud" are now capitalized
  • The Inspect Results cell now truncates all but the first and last results in the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants