Fix Library.add()
method to properly apply advanced settings
#1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
Library.add()
is appending any advanced settings to the end of thepart
. This ends up making for boguslocations
as thelocations
param is the last in line. Also, each advanced settings needs to be prefixed withprefs
and the be contained in brackets (pref[id]=value,...
).We also don't have any tests for adding sections with advanced settings. I created an addtional test isolated to adding a section with advanced settings.
See
LibrarySection.editAdvanced()
method for confirmation.Type of change
Please delete options that are not relevant.
Checklist: