Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Library.add() method to properly apply advanced settings #1384

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

blacktwin
Copy link
Collaborator

Description

Currently Library.add() is appending any advanced settings to the end of the part. This ends up making for bogus locations as the locations param is the last in line. Also, each advanced settings needs to be prefixed with prefs and the be contained in brackets (pref[id]=value,...).

We also don't have any tests for adding sections with advanced settings. I created an addtional test isolated to adding a section with advanced settings.

See LibrarySection.editAdvanced() method for confirmation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 force-pushed the Library_add_advanced_settings branch from 90818dc to 38b305f Compare March 16, 2024 22:20
Add section deletion after testing
@JonnyWong16 JonnyWong16 merged commit 5b5d4c6 into master Mar 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants