Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typehints for remaining methods of PlexObject #1344

Open
wants to merge 20 commits into
base: typehints
Choose a base branch
from
Open

Typehints for remaining methods of PlexObject #1344

wants to merge 20 commits into from

Commits on Nov 16, 2023

  1. add type hints 

    - base.py passes for pyright and mypy
    @Dr-Blank
    Dr-Blank committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    3425590 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary inheritance from Playlist 

    class.
    @Dr-Blank
    Dr-Blank committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    dfe293b View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary inheritance from Photo class.

    @Dr-Blank
    Dr-Blank committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    495c394 View commit details
    Browse the repository at this point in the history

  4. Fix issue with casting None values in utils.py

    @Dr-Blank
    Dr-Blank committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    88137bf View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @Dr-Blank
    Dr-Blank committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    49c6dd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. More Code refctoring with typehints

    @Dr-Blank
    Dr-Blank committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    29a93ea View commit details
    Browse the repository at this point in the history

  2. Add datetime module and update function signatures

    @Dr-Blank
    Dr-Blank committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d30c1a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Implement requested changes

    @Dr-Blank
    Dr-Blank committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1231a9c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. document reason for multiple overloads

    @Dr-Blank
    Dr-Blank committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d940c27 View commit details
    Browse the repository at this point in the history

  2. apply requested changes regarding formatting and code refactoring

    @Dr-Blank
    Dr-Blank committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    90db72c View commit details
    Browse the repository at this point in the history

  3. Sort imports 

    - annotations import in all files using typehints
- typehint specific imports under type_checking condition
- native library imports > installed libs > module import
    @Dr-Blank
    Dr-Blank committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    dfbc682 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. apply suggestions 

    - fix _INCLUDES attr by including an empty dict
- add explicit return types for methods missing them
    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d4fc723 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'typehints' into code/typehints

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    39394aa View commit details
    Browse the repository at this point in the history

  3. revert import statements as suggested

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d6754c0 View commit details
    Browse the repository at this point in the history

  4. Update reload method signature

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    9c9394a View commit details
    Browse the repository at this point in the history

  5. Refactor _checkAttrs method to use type hints for attrsFound

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8c86aaa View commit details
    Browse the repository at this point in the history

  6. Add type hint to _getAttrOperator method

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b7cf403 View commit details
    Browse the repository at this point in the history

  7. Refactor _loadData and serachType method signature

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e01ffdb View commit details
    Browse the repository at this point in the history

  8. Update __setattr__ method signature

    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    36be80d View commit details
    Browse the repository at this point in the history

  9. overloads for _clean 

     - need to explicitly return None to satisfy mypy
    @Dr-Blank
    Dr-Blank committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3e8ff69 View commit details
    Browse the repository at this point in the history