Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cast function in utils.py #1340

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Refactor cast function in utils.py #1340

merged 1 commit into from
Feb 4, 2024

Conversation

Dr-Blank
Copy link
Contributor

@Dr-Blank Dr-Blank commented Jan 16, 2024 •
edited

Description

ref: #1302 (comment)

  • less indentation, more readable code
  • early return

Type of change

Please delete options that are not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@Dr-Blank
Refactor cast function in utils.py
2fea63c 
- less indentation, more readable code
- early return
@JonnyWong16 JonnyWong16 merged commit ba384e0 into pkkid:master Feb 4, 2024
5 checks passed
@Dr-Blank Dr-Blank deleted the code-quality branch February 5, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonnyWong16 JonnyWong16 JonnyWong16 approved these changes

Assignees
No one assigned
Labels
non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dr-Blank @JonnyWong16