Update dependencies and CodePane fixes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just need to use it for now. Maybe revisit this using a variant.
Adjusts for a change in Enzyme shallow types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I squashed the commits that dealt with updating dependencies and build artifacts into one commit here and rebased everything on master. This makes it a bit more clear what's going on. The diff is large because the snapshot format was updated and now has more information. Everything passes on CI enabled for my fork.
This worked well enough for me for a presentation last week, although there seems to be a problem with CodePane on a production webpack build (but not in development mode) that I don't quite understand. Using CodePane at all in production mode gives a white screen on that slide due to a trying to access a value that is undefined. However, that issue is there even on your master branch, so it's not a regression introduced here. I'll probably file a separate issue somewhere about this as soon as I can narrow down where the problem lies. It might be an issue in either spectacle or webpack for all I know.
I would prefer not to maintain a fork, so please let me know if you have any concerns and I will happily address them.