Remove non-functional if-failed code and warn

[goose121]

The way that the :if-failed argument to with-ftp-connection is
handled does not work. make-instance should never return nil, and
any errors signalled within initialize-instance will still be
signalled. I feel it would probably be futile to try and make it work
for the errors which this library signals, as connect-to-server
calls other functions which don't have an argument to avoid
signalling, so the client may be better served with ignore-errors or
similar.

[pinterface]

Your analysis seems reasonable, and the patch looks like it should work, though I don't have an environment set up to test it at the moment. I'll, uh, have to remedy that. As you note, getting `:if-failed` to work at all is likely to be more trouble than it would be worth, so my initial inclination is to deprecate it, rather than merely warn of non-functionality. (In other words, warn if it was specified at all, with the intent of removing the argument at some point in the future.) I'm a little sad I don't have anything prior to version 1.3 to go code spelunking through, to try and figure out how it ended up that way, but alas. Before my time! That said, looking at the history I do have, if it doesn't work now it hasn't worked for /at least/ 13 years, so odds are good nobody is relying on `:if-failed`. Anyway, I'm rambling. Thanks! It's going to take me longer than I'd like to get this (or something similar) merged in, but I appreciate the analysis and patch.

…

On 11/26/21 5:44 PM, goose121 wrote: The way that the `:if-failed` argument to `with-ftp-connection` is handled does not work. `make-instance` should never return `nil`, and any errors signalled within `initialize-instance` will still be signalled. I feel it would probably be futile to try and make it work for the errors which this library signals, as `connect-to-server` calls other functions which don&#39;t have an argument to avoid signalling, so the client may be better served with `ignore-errors` or similar. You can view, comment on, or merge this pull request online at: #4 -- Commit Summary -- * <a href="https://github.com/pinterface/cl-ftp/pull/4/commits/1077b22587e43c8c2c236ae3b527850bc9b521a9">Remove non-functional if-failed code and warn</a> -- File Changes -- M ftp.lisp (10) -- Patch Links -- https://github.com/pinterface/cl-ftp/pull/4.patch https://github.com/pinterface/cl-ftp/pull/4.diff