Environment variables for default port and bind address #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurushao
reviewed
Apr 17, 2024
| ``BIND_ADDRESS``: (optional) Used to override the default bind address of 0.0.0.0 for flask app Example: ``127.0.0.1`` | ||
|
|
||
| ``PORT``: (optional) Used to override the default port of 5000 Example: ``6000`` | ||
|
|
There was a problem hiding this comment.
Can we prefix them with SNAPPASS_?
There was a problem hiding this comment.
Sure thing, I just made those edits. Thanks for taking a look!
Prefix bind address and port with SNAPPASS_
update readme to prefix SNAPPASS_ to bind address and port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is not an open issue for this but I ran into an issue where I could not change the default port or bind address for snappass. In my case I installed via pip and wanted to bind snappass to 127.0.0.1 as I am planning to use a reverse proxy to reach the app. Is it possible to add the following two environment variables?
BIND_ADDRESS = 127.0.0.1
PORT = 6000
I tested that with no environment variables set, the defaults of 0.0.0.0:5000 are set and working. Given the following variables
I can reach the app and links are generated with the appropriate URL.
ps. This is my first time submitting a PR, I apologize if I am missing anything.
Thanks all!