Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "report abuse" prompts for users (disabled by default) #112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0secure
Copy link

@0secure 0secure commented Oct 10, 2019

This change adds two new environment variables (ABUSE_ORG and ABUSE_EMAIL) that are used to direct users to contact a particular organization in case of suspected abuse. In addition, a generic 404 page and a secret-specific 404 page are added to minimize confusion and direct users to report abuse. If neither environment variable is set, the prompt to report abuse is not shown.

Copy link
Collaborator

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use spaces around operators, commas, etc. to match the existing style.

snappass/main.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Could you also document the new configuration keys in the README.rst file?

<p>The secret you requested is not available. This typically indicates that one of the three below conditions has occurred:</p>
<ol>
<li>The secret has already been retrieved.</li>
<li>The link was corrupted</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the other items in the list:

Suggested change
<li>The link was corrupted</li>
<li>The link was corrupted.</li>

@jparise
Copy link
Collaborator

jparise commented Nov 4, 2019

@0secure just wanted to follow up on adding some README.rst documentation for this new feature so we can merge it.

@jparise
Copy link
Collaborator

jparise commented Jan 12, 2021

@0secure do you think you'll be picking this work back up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants