fix: add bom to downloaded csv for excel #1430
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you download the result of a query as a CSV and then open the result in Excel, there are encoding issues for unicode/non-latin characters. This PR makes the process of opening a downloaded CSV in Excel a little smoother by adding the Byte Order Mark to the downloaded CSV. There is not a pressing issue with Querybook right now, Excel is just very particular and this makes the downloaded CSVs play nice with Excel's strange encoding import rules.
Example of Issue: Upload the following table and run
SELECT * FROM <your-schema>.non_latin_test
, then download the results of the query executionnon_latin_test.csv
Opening the result CSV in Excel used to give the following:
This PR adds the BOM so that Excel is happy and gets the right encoding: