feat: Added support for sending custom datadog metrics from querybook #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Jan 3, 2024
|
Datadog is now an optional dependency |
|
@czgu can you help to look the PR again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the setup of
dogstatsd, a python library used for sending metrics to Datadog as well as the creation of a new stats logger,DatadogStatsLogger.In addition, it includes 5 metrics:
celery.active_workers,celery.active_tasks,task.received,task.failures, andtask.successesThe first 2 metrics are sent to datadog every 5 seconds by opening a new thread which continuously runs the
send_stats_logger_metricsfunction. The other 3 metrics are triggered by event handlers so they are sent whenever a task is received by a worker, a task fails, or a task succeeds.