Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize unnecessary column copy for HashAgg #8985

Merged
merged 60 commits into from
May 29, 2024
Merged

Optimize unnecessary column copy for HashAgg #8985

merged 60 commits into from
May 29, 2024

Commits on Apr 23, 2024

  1. tmp save 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    60bd8ea View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. refine for spill(enable_skip_serialize_key arg) 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a857c53 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ee3d867 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. fmt 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fac85e5 View commit details
    Browse the repository at this point in the history

  2. map -> set 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f78ddbf View commit details
    Browse the repository at this point in the history

  3. tidy 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b1c98fa View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. fix 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2f6eb26 View commit details
    Browse the repository at this point in the history

  2. fix 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b4d72ea View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5b7a84c View commit details
    Browse the repository at this point in the history

  4. use unordered_map as key_from_agg_func 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    bd66dec View commit details
    Browse the repository at this point in the history

  5. reorder collator && fix insert key helper crash 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e78cbce View commit details
    Browse the repository at this point in the history

  6. disable opt for spill process 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6ef75b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. fix prepareBlockAndFill for spill 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d009d19 View commit details
    Browse the repository at this point in the history

  2. fmt 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    881141f View commit details
    Browse the repository at this point in the history

  3. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9914d0b View commit details
    Browse the repository at this point in the history

  4. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    76e75fc View commit details
    Browse the repository at this point in the history

  5. tidy 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f0c7302 View commit details
    Browse the repository at this point in the history

  6. refine 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d9e8880 View commit details
    Browse the repository at this point in the history

  7. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    addd8d3 View commit details
    Browse the repository at this point in the history

  8. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6751837 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. update comment 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ffd5c4e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. agg_func_ref_key optimization; gtest 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 6, 2024
    Configuration menu
    Copy the full SHA
    cbf8de5 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. append copy column action after agg 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c0cb939 View commit details
    Browse the repository at this point in the history

  2. case && fmt 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ede3a80 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b62ed01 View commit details
    Browse the repository at this point in the history

  4. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0d0d74b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. fix case by integrate enable_convert_key_optimization into fianl flag 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 8, 2024
    Configuration menu
    Copy the full SHA
    65e33d5 View commit details
    Browse the repository at this point in the history

  2. refine 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b0b1df7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7b1c0b8 View commit details
    Browse the repository at this point in the history

  4. fmt 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2240c9b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. add check for shuffle key not compatible with key_ref_agg_func 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 22, 2024
    Configuration menu
    Copy the full SHA
    df112a8 View commit details
    Browse the repository at this point in the history

  2. refine gtest 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 22, 2024
    Configuration menu
    Copy the full SHA
    dcd81b8 View commit details
    Browse the repository at this point in the history

  3. refine comments 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f1dd218 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed May 22, 2024
    Configuration menu
    Copy the full SHA
    69e3509 View commit details
    Browse the repository at this point in the history

  5. lint 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c312346 View commit details
    Browse the repository at this point in the history

  6. dbg 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ea15bd7 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1d66cdb View commit details
    Browse the repository at this point in the history

  2. fmt 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0a51cff View commit details
    Browse the repository at this point in the history

  3. more check 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 23, 2024
    Configuration menu
    Copy the full SHA
    8f4a577 View commit details
    Browse the repository at this point in the history

  4. use first_row instead of any 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 23, 2024
    Configuration menu
    Copy the full SHA
    aef88e2 View commit details
    Browse the repository at this point in the history

  5. del useless Params ctor 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f233a5c View commit details
    Browse the repository at this point in the history

  6. fix InterpreterSelectQuery 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e8ae06e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. refine aggregate_output_columns logic 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3228bf6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f6d29e8 View commit details
    Browse the repository at this point in the history

  3. fix case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 24, 2024
    Configuration menu
    Copy the full SHA
    827533d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Revert "fix case" 

    This reverts commit 827533d.
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4834e00 View commit details
    Browse the repository at this point in the history

  2. Revert "refine aggregate_output_columns logic" 

    This reverts commit 3228bf6.
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    93cb868 View commit details
    Browse the repository at this point in the history

  3. key name 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a4cb243 View commit details
    Browse the repository at this point in the history

  4. remove eliminate any 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    08595ce View commit details
    Browse the repository at this point in the history

  5. comment/ctor/operator 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    29f993c View commit details
    Browse the repository at this point in the history

  6. comment 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1fce8cc View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:pingcap/tiflash into optimize_dup… 

    …licated_agg_func
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    435f850 View commit details
    Browse the repository at this point in the history

  8. case 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 27, 2024
    Configuration menu
    Copy the full SHA
    478bc9f View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. unique_ptr for buildParams() 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 28, 2024
    Configuration menu
    Copy the full SHA
    df059e0 View commit details
    Browse the repository at this point in the history

  2. check first_row_type 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 28, 2024
    Configuration menu
    Copy the full SHA
    be21ad4 View commit details
    Browse the repository at this point in the history

  3. refine findFirstRow 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3c37638 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. fix wrong if 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 29, 2024
    Configuration menu
    Copy the full SHA
    240f816 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into optimize_duplicated_agg_func

    @guo-shaoge
    guo-shaoge committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7d9e7e3 View commit details
    Browse the repository at this point in the history

  3. comment && collators using map instead of vector 

    Signed-off-by: guo-shaoge <shaoge1994@163.com>
    @guo-shaoge
    guo-shaoge committed May 29, 2024
    Configuration menu
    Copy the full SHA
    53112b1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into optimize_duplicated_agg_func

    @ti-chi-bot
    ti-chi-bot[bot] committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c517463 View commit details
    Browse the repository at this point in the history